SundayServiceVR / sunday-service-vr

1 stars 1 forks source link

Better Firebase Typing #59

Open lebull opened 1 month ago

lebull commented 1 month ago

Right now, there's methods like "docToEvent" to convert a firebase document to a strongly typed object. It looks like we probably should be using something like this:

https://react-query-firebase.invertase.dev/firestore/typescript https://firebase.google.com/docs/reference/node/firebase.firestore.FirestoreDataConverter

We also should figure out if we need to swap from native Date objects to firebase's timestamp.

lebull commented 1 month ago

As of right now, what we have seems to be working "alright", so we can probably just hold off on doing this unless we run into issues or see a real benefit to doing it the 100% "right" way