search

Sundsvallskommun / OpenEMap-WebUserInterface

Open eMap user interface for the main map client
GNU Affero General Public License v3.0
4 stars 5 forks source link

Search - does not work at some occations #91

Closed anderserla closed 10 years ago

anderserla commented 10 years ago

The users have had problems searching parcels in Sundsvall at some occations. Se attached image. errorsearchparcels

anderserla commented 10 years ago

Have you managed to reproduce this error @sweco-sebhar ?

ghost commented 10 years ago

No never seen it :(

anderserla commented 10 years ago

We dont act on it any more right now. Wait and see if it will appear again.

anderserla commented 10 years ago

I think we'll have to look into this problem a little bit more.

There are more users reporting problems with search. It often happens when the user makes a new search before the answer of the previous has returned.

Would it be possible to put a longer delay between stop writing and start searching?

ghost commented 10 years ago

Ok I'll try to reproduce. How would it help increasing the delay?

ghost commented 10 years ago

Ok I think I understand what is going on now. If a new search is triggered and is responding faster than a previously issued but unfinished search the results presented will be overwritten by the first search.

If the above is correct I think there is two possible ways to fix it:

  1. Make sure any unfinished searches are aborted if a new search is triggered.
  2. Disallow new search until a search is completed.

I'll try to implement alternative 1.

ghost commented 10 years ago

Alternative 1 cannot be done without changes in Ext JS 4 (afaik), so I implemented alternative 2.

anderserla commented 10 years ago

OK The delay is so short that it often happens that a search starts before the user stops writing, resulting in multiple searches. It happens because it is hard to type an estate expression without pause, cus there are often letters, digits and colons included in the expression.

anderserla commented 10 years ago

Works for me. I will let some other users verify this too.

anderserla commented 10 years ago

What is the time to make alt 1? And is it possible to put it back into ExtJS source? and time for that?

anderserla commented 10 years ago

I think it would be better to use the previous solution, rather than this fix. It is too confusing for the end user. Back code to be as it was before the fix.

Add some time for the delay. Maybe 0.8 secs?

After that put some time to analyse alt 1.

ghost commented 10 years ago

Changes reverted and delay changed to 800 ms.

ghost commented 10 years ago

Implemented workaround (alternative 1) described here: http://stackoverflow.com/questions/15237011/extjs-4-remote-combobox-abort-previous-request

anderserla commented 10 years ago

Works perfect for Fastighet. Not implemented for Adress and Ortnamn?

ghost commented 10 years ago

Då ska de vara fixat!

anderserla commented 10 years ago

Great!