search

SungMatt / pe

0 stars 0 forks source link

Shock to user after clearing courses #2

Open SungMatt opened 9 months ago

SungMatt commented 9 months ago

Great work! I got a little shock after I cleared the courses using clear-courses, and all my friends disappeared!

Turns out it was just that I had tried to list those taking the same course as me.

Perhaps it would be great when clear-courses is invoked, such that the whole list of friends is visible again?

Steps to reproduce:

  1. list friends taking a course
  2. clear-courses
  3. GET SHOOK
nus-pe-bot commented 9 months ago

Team's Response

Thank you for the bug report! We hope that you have recovered from the little shock you got.

However, we have decided that this is a feature flaw, not a functionality bug as you mentioned. The commands worked exactly the way we had envisioned.

When you had listed your friends who took a particular course, a filtered list of friends was returned to you. Your subsequent command, clear-courses, removed all courses from your friends. The filtered list was then automatically updated. However, there was no one in your updated filtered list, because you have stripped your friends of all their courses and all your friends no longer have the course you mentioned in Step 1.

We will, of course, take this into consideration for future versions of NUSCoursemates to prevent others from getting SHOOK :)

Items for the Tester to Verify

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]