SungMatt / pe

0 stars 0 forks source link

UG: Phone numbers of overseas friends, but country codes are not supported. #4

Open SungMatt opened 9 months ago

SungMatt commented 9 months ago

"Stay connected with your local and overseas friends whose phone numbers may be of different lengths."

Overseas friends unfortunately come with country codes and area codes!

Example: (659) 123-4567 is not the same as +65 91234567. Is there a way to incorporate this in?

nus-pe-bot commented 9 months ago

Team's Response

Thank you for your suggestion! We appreciate your input regarding the criteria for a phone number.

Although this aspect is good to have but not critical and has a lower priority than the work we already done in v1.4, we're open to modifying our current restrictions for phone numbers.

However, as outlined in our User Guide, we only accept phone numbers that are at least 3 digits long and consist solely of numbers.

Based on these criteria, your suggestion falls outside our current scope and it behaves the same as our User Guide mentioned (I have attached the screenshot of that part below), so we will change the bug type to FeatureFlaw instead. Nevertheless, we value your feedback and consider it a great suggestion.

Screenshot 2023-11-20 at 12.51.28 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Thanks for the well-written response.

I understand where you guys are coming from! However, the promise made in the User Guide, under "Features - Managing Student Profiles -> Adding a Student" was to connect with both local and overseas friends, which now necessitates the need to discern phone numbers. I have attached a screenshot of the appropriate section below.

Screenshot 2023-11-23 at 12.58.32 AM.png

If the target, as stated, was to allow communication with local and overseas friends, this problem with country and area codes is inevitable. It will then be imperative to hold these numbers properly, so we don't connect to a new friend-to-be and lose our overseas friend! This is especially important when accounts (like WhatsApp accounts) can only be registered to a single phone number -- and that phone number could be based in the overseas country; and can be confused with another local phone number.

As stated above, here's an example of a number from Birmingham, Alabama, United States -- that could be confused with a Singapore number: (659) 123-4567, +65 9123 4567.

I concur with your reclassification of a Feature Flaw though -- thanks for modifying that appropriately. Thank you very much!


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]