search

SungMatt / pe

0 stars 0 forks source link

SortCommandParser disclaimer in DG is not necessary #8

Open SungMatt opened 9 months ago

SungMatt commented 9 months ago

Screenshot 2023-11-17 at 5.37.31 PM.pngScreenshot 2023-11-17 at 5.37.31 PM

SortSequenceDiagram1.png

Looks OK to me!

nus-se-script commented 9 months ago

Team's Response

Thank you for your bug report.

The diagram looks OK to us too!

While we believe that the disclaimer is not necessary, it is much better to have the disclaimer in the DG to better inform readers of the red 'X' placed on the lifeline of SortCommandParser.

We would also like to take this opportunity to highlight the difference between a lifeline and an activation bar. A lifeline is represented by the dotted line, while an activation bar is represented by the thick white bars.

In this case, the lifeline (dotted line) of SortCommandParser object is supposed to end after it is no longer needed. However, due to PlantUML limitations, the lifeline continues. The activation bar, on the other hand, ends at an appropriate juncture.

We do not see anything wrong with the diagram, hence, we reject this bug report.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]