Closed estahn closed 7 years ago
@kmcgrath See #10
@kmcgrath Did you have a chance to look at the pull requests?
@estahn thank you for the requests. I have seen them, but won't be able to give them a good look until tomorrow or Saturday.
They are in my queue ;)
I like this idea.
Implemented something similar in spotinst-lambda
At the time the decision was to push logs to downstream projects to keep lambda-formation as light as possible. With that said, logs are a very fundamental thing that should probably be supported by the framework.
Running short on time tonight, but will come back to this tomorrow. Just want to compare what we did before and this.
Yes, I think I copied the winston part from cfn-responder
. The only bit I dislike is the use of process.env.CFN_LOG_LEVEL
directly in lib/logger/index.js
.
It might be a better idea to do something with a config object, e.g.
var LambdaFormation = require('lambda-formation');
LambdaFormation.config.log_level = process.env.CFN_LOG_LEVEL;
And use this in lib/logger/index.js
.
Thanks again for the submission! #10 has been merged.
This is a feature request to add logging out of the box.
var log = require('lambda-formation').logger;
projectHandler
andresourceHandler
should always log arguments with log-leveldebug