SungchulCho / v8-juice

Automatically exported from code.google.com/p/v8-juice
Other
0 stars 0 forks source link

Compiler error. #32

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
In my application I have a class called Value in the global namespace, which 
makes the compiler complain about the ClassCreator. The method ctor_proxy 
contains:

using namespace v8;

and then uses Value, which normally would be v8::Value, but now results in my 
global ::Value.

Could you apply the changes in the attached file?

Original issue reported on code.google.com by nicokrui...@gmail.com on 17 Jul 2012 at 3:13

Attachments:

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
I will fix this but i am not happy about it lbecause it means my library has to 
fully-qualify the names due to a collision in your code. This is proabably not 
the onlg place where i use "using". 

Original comment by sgbeal@googlemail.com on 17 Jul 2012 at 7:22

GoogleCodeExporter commented 8 years ago

Original comment by sgbeal@googlemail.com on 17 Jul 2012 at 7:24

GoogleCodeExporter commented 8 years ago
Thanks for fixing this issue. I'll see whether there is a cleaner solution that 
works for me as well.

Original comment by nicokrui...@gmail.com on 17 Jul 2012 at 8:52

GoogleCodeExporter commented 8 years ago
i unfortunately won't have access to my dev machine until Friday night, but 
will get this committed over the weekend. If you do not hear back from me (via 
this ticket) by Saturday, please post a comment here and i'll see the reminder.

Original comment by sgbeal@googlemail.com on 17 Jul 2012 at 4:01

GoogleCodeExporter commented 8 years ago
i've thought this through some more and my initial reaction was wrong - cvv8 
should not use 'using' at all. i did not foresee this particular problem at the 
time, but it is a real issue and will be fixed. i only have my dev machine on 
the weekends, so it will have to wait until Friday or Saturday, but i'll get 
this done soon.

Thanks for the bug report (and for nailing down the exact problem - it would 
have taken me a long time to figure it out, probably!), and Happy Hacking!

Original comment by sgbeal@googlemail.com on 18 Jul 2012 at 3:45

GoogleCodeExporter commented 8 years ago
Thanks for the fast response and fix.

Happy coding to you too,
Nico

Sent from my iPad

On 18 jul. 2012, at 17:45, "v8-juice@googlecode.com"
<v8-juice@googlecode.com> wrote:

Original comment by nicokrui...@gmail.com on 20 Jul 2012 at 10:06

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r2257.

Original comment by sgbeal@googlemail.com on 20 Jul 2012 at 10:25