Open sync-by-unito[bot] opened 4 years ago
➤ Umair Aslam commented:
The fix will be on both electron app and spaces-front.
➤ Flavio Peralta commented:
@Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) here is the PR with the workaround fix we talked about to load the URL that comes on deep link instead of perform an internal routing https://github.com/esna/spaces-front/pull/3444. This is a minor change on electron app side only.
➤ Ray Gerami commented:
@Umair Aslam ( https://app.asana.com/0/1153071673779409/calendar ), please wait on this PR until we make our decision on the Plan A or B. This Fix is good for Plan A
➤ Umair Aslam commented:
@Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar )@Flavio Peralta ( https://app.asana.com/0/1182240586515905/list ) SInce we are doing Plan B now, I am assigning it back to Flavio.
➤ Flavio Peralta commented:
PR is on #103 ⁃ Fix Deep Link for spaces with pin ( https://app.asana.com/0/1183131807549409/1191323627363921/f )
Description:
Expected behavior User2 should be prompted to enter pin again instead of being stuck with infinite loading screen
please use the Electron App installers from here https://drive.google.com/file/d/1gBlXAt5zMpCKT7ldoaD9FLvHtkP5Q_bg/view?usp=sharing.