Sunny-Lau / dirty-room

GNU General Public License v3.0
0 stars 0 forks source link

Start button shows disabled once in a while for Anonymous guests.(4seconds) #9

Open sync-by-unito[bot] opened 4 years ago

sync-by-unito[bot] commented 4 years ago

One of the spaces impacted https://spaces.zang.io/spaces/5ed507939c9b2ab0c054fbc3 Time: 17:58 IST July 6th - 8:28 a.m EST.

What is the config or machine type of the VM - n1-standard-4 (4 vCPUs, 15 GB memory)

"Based on my logs checking and my testing. I found some static files delay is very long. For example the failure testing you claimed at 11:40 this morning, I found a request to fontawesome-webfont.af7ae505.woff2 take near 4 second. And I got another delay to another static file take more than 5 seconds. But I never get very long delay on rest api."

┆Attachments: font-awesome.min.css | font-awesome-4.7.0.zip

sync-by-unito[bot] commented 4 years ago

➤ Rohit Moza commented:

https://spaces.zang.io/spaces/5e7282ec58b1f9d7f80da1fe 8:21am EST 6th July

https://spaces.zang.io/spaces/5ed502ec3ceae5579ea936bd 12:06PM EST 4th July

sync-by-unito[bot] commented 4 years ago

➤ Rohit Moza commented:

"Based on my logs checking and my testing. I found some static files delay is very long. For example the failure testing you claimed at 11:40 this morning, I found a request to fontawesome-webfont.af7ae505.woff2 take near 4 second. And I got another delay to another static file take more than 5 seconds. But I never get very long delay on rest api."

sync-by-unito[bot] commented 4 years ago

➤ Adrian Lee commented:

@Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) Hong mentioned that you had assigned someone to look at reducing the download of fonts to help reduce loading time. Can you please have the developer add comments to this task or reassign this task to the developer?

sync-by-unito[bot] commented 4 years ago

➤ Ray Gerami commented:

@Jeff Yu ( https://app.asana.com/0/1179813771897518/calendar ), can. you investigate and see what fonts are we using from font-awsome can we only import only the icons we are using instead of loading this large library. If not can we use equivalent font from material-design which allows us to load partially.

sync-by-unito[bot] commented 4 years ago

➤ Jeff Yu commented:

@Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) The lagging from loading static files are very common, usually the best solution is to use CDN, like cloudflare

sync-by-unito[bot] commented 4 years ago

➤ Jeff Yu commented:

@Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) Since this issue was spotted by a Bot, I suggest lets try the CDN solution and see if the bot ever complains about it again. Please see PR - https://github.com/esna/spaces-front/pull/3125

sync-by-unito[bot] commented 4 years ago

➤ Ray Gerami commented:

@Jeff Yu ( https://app.asana.com/0/1179813771897518/calendar ), the issue with this cdn is that some customers may have restrict firewall rules and may not allow such domain to be whitelisted. I suggest to identify areas where we may use font-awsome and then decide on a solution,

sync-by-unito[bot] commented 4 years ago

➤ Jeff Yu commented:

@Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) The other approach might be host the font awesome files on google cloud CDN. That would avoid the firewall issue and fasten the loading speed right?

sync-by-unito[bot] commented 4 years ago

➤ Ray Gerami commented:

@Jeff Yu ( https://app.asana.com/0/1179813771897518/calendar ), if we don't get cross domain issue, and you think gcs would solve the issue it' is ok.

sync-by-unito[bot] commented 4 years ago

➤ Ray Gerami commented:

@Jeff Yu ( https://app.asana.com/0/1179813771897518/calendar ), you can attach the necassary files to this asana item, I'll try to upload it to our public gcs and send you the link to update the PR.

sync-by-unito[bot] commented 4 years ago

➤ Jeff Yu commented:

@Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) Ive checked we are using v4.7.0 font awesome, please see attached file here. Let me know the gcs link.

sync-by-unito[bot] commented 4 years ago

➤ Ray Gerami commented:

@Jeff Yu ( https://app.asana.com/0/1179813771897518/calendar ), here is the link to public url on our gcs

https://storage.googleapis.com/spaces2020/public/spaces/statics/font-awesome.min.css

sync-by-unito[bot] commented 4 years ago

➤ Jeff Yu commented:

@Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) Hey ray, sorry i just found out u actually need to upload the whole font-awesome package in order to make it work, not just 1 file. Here is the new zip. can you unzip the contents into gcs and send me the link plz. Need to make all the contents under this folder public accessible.

The reason is font-awesome need the woff font files to work, along with css files.

sync-by-unito[bot] commented 4 years ago

➤ Ray Gerami commented:

@Jeff Yu ( https://app.asana.com/0/1179813771897518/calendar ), I uploaded the whole folder and this is the link to https://storage.googleapis.com/spaces2020/public/spaces/statics/font-awesome-4.7.0/css/font-awesome.min.css

See if it works. If so please redo the PR based on mute all phase I branch

sync-by-unito[bot] commented 4 years ago

➤ Jeff Yu commented:

@Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) The link is working, new PR - https://github.com/esna/spaces-front/pull/3272. Is this link a CDN or just standard cloud storage?

sync-by-unito[bot] commented 4 years ago

➤ Ray Gerami commented:

this is just a standard cloud storage

sync-by-unito[bot] commented 4 years ago

➤ Ray Gerami commented:

@Jeff Yu ( https://app.asana.com/0/1179813771897518/calendar ), does the code is running ok locally now with this new change?

sync-by-unito[bot] commented 4 years ago

➤ Jeff Yu commented:

@Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) Yes it is working fine now

sync-by-unito[bot] commented 4 years ago

➤ Ray Gerami commented:

@Jeff Yu ( https://app.asana.com/0/1179813771897518/calendar ), sorry for going back and forth, can you redo this based on feature/candidate? we have decided to not release mute-all-phase 1

sync-by-unito[bot] commented 4 years ago

➤ Jeff Yu commented:

@Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) Sure,New PR to feature/candidate - https://github.com/esna/spaces-front/pull/3309

sync-by-unito[bot] commented 4 years ago

➤ Ajitesh Kumar commented:

@Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) why is it assigned to me ? is there any action item on me ?

sync-by-unito[bot] commented 4 years ago

➤ Ray Gerami commented:

Hi Ajitesh, this was reported by bestol automated script so we need some one from there to validate it.

sync-by-unito[bot] commented 4 years ago

➤ Ajitesh Kumar commented:

Hi @Ray Gerami ( https://app.asana.com/0/1154145881585295/calendar ) - The code has been changes for the BOT framework and we wouldnt be able to validate it

sync-by-unito[bot] commented 4 years ago

➤ Adrian Lee commented:

Hi @Ajitesh Kumar ( https://app.asana.com/0/1175287639608301/list ) Can you give more details about why this couldn't be validated by the automation tool anymore? Assuming there is still a test that attempts to click on the Start button the automation test should be able to test it.

sync-by-unito[bot] commented 4 years ago

➤ Ajitesh Kumar commented:

Hi @Adrian Lee ( https://app.asana.com/0/1160180399511248/list ) - We changed the Automation framework wait time to a bigger time and the image is pushed now in the lab... This was done to avoid the tests failing continuosly.