SunnyApp / flutter_contact

A flutter plugin for retrieving, creating, saving, and watching contacts on native devices
BSD 3-Clause "New" or "Revised" License
81 stars 62 forks source link

Fix Android arbitrary date string parsing #64

Closed mabdurrahman closed 3 years ago

mabdurrahman commented 3 years ago

Thanks for your great fork, I have been using it in production for a while and it works great, however, I hit an issue with one of my app's customers who is using an Android device because of a non-standard arbitrary birthday string in one of his contacts and I was able to reproduce the same issue using the example app.

I understand that the library has been migrated already to flexidate plugin for better date parsing, however, the issue is still reproducible, please check the steps to reproduce below for more details.

Steps to reproduce:

  1. Use an Android device with their contacts synced to Google Contacts
  2. Opened one of the synced contacts via Google Contacts web UI (https://contacts.google.com/)
  3. Edit the contact
  4. Show more fields
  5. Add a non-standard arbitrary birthday string (i.e. 7 July 1960)
  6. Wait for the contact to be synced back to the mobile device
  7. Open the example app

Expected:

Actual:

ericmartineau commented 3 years ago

Thanks for this catch. I ended up handling this slightly differently, but the change will be present in the next release