Morning session - P2P CR - 08/10

[dicodiaz]

Hello @SunnySparks, this issue will be used for giving our comments/suggestions.

[ramiaquista]

Awesome Job! 💯

I would recommend you to try to avoid unnecessary in-line comments and probably it would be a great idea if you can optimize your code where you interpolate background li colors.

Keep coding in the same way 😄

[dicodiaz]

You're doing an amazing job!

I have a couple of suggestions to reduce the lines of your code and make it faster:

• The way you access the response data in the lines https://github.com/SunnySparks/Leaderboard-JS/blob/ebfdc58151e7d6d238dedb2beeeb3568c40fb3cd/src/index.js#L66-L67 could also be done like this: const leaderboard = data.result;
• The way you get the index inside the forEach https://github.com/SunnySparks/Leaderboard-JS/blob/ebfdc58151e7d6d238dedb2beeeb3568c40fb3cd/src/index.js#L72-L73 could be avoided by calling the forEach like this: leaderboard.forEach((element, index) => {...})

That's it. Keep up the good work! 😄