Closed ddahlbom closed 8 months ago
This looks nice and clean! The three new package dependencies (Downloads, Tar, CodecZlib) all seem pretty "Julia official".
The PR currently extracts into ./contributed-tmp
and then copies to src/examples/contributed
. Is there a reason not to directly extract into the latter?
Tar.extract(tar, joinpath(@__DIR__, "src", "examples", "contributed")
Then we would no longer need contributed-tmp
?
This PR addresses Issue #203. The Sunny doc building process no longer attempts a sparse checkout of the SunnyContributed build folder. Instead, the make file on the SunnyContributed side now stores the results of its build in a tarball, and this tarball is downloaded directly during the Sunny.jl doc build without using git.
Associated changes to SunnyContributed were made in this commit (see changes to
make.jl
).