SunnySuite / Sunny.jl

Spin dynamics and generalization to SU(N) coherent states
Other
79 stars 19 forks source link

Download contributed docs as .tgz #213

Closed ddahlbom closed 8 months ago

ddahlbom commented 8 months ago

I messed up a rebase, so I am redoing PR #210 here.

As before:

This PR addresses Issue #203. The Sunny doc building process no longer attempts a sparse checkout of the SunnyContributed build folder. Instead, the make file on the SunnyContributed side now stores the results of its build in a tarball, and this tarball is downloaded directly during the Sunny.jl doc build without using git.

Associated changes to SunnyContributed were made in this commit (see changes to make.jl).

@kbarros left the following comment on the earlier PR:

This looks nice and clean! The three new package dependencies (Downloads, Tar, CodecZlib) all seem pretty "Julia official".

The PR currently extracts into ./contributed-tmp and then copies to src/examples/contributed. Is there a reason not to directly extract into the latter?

    Tar.extract(tar, joinpath(@__DIR__, "src", "examples", "contributed")

Then we would no longer need contributed-tmp?

The suggestion has been incorporated.