SunnySuite / Sunny.jl

Spin dynamics and generalization to SU(N) coherent states
Other
65 stars 19 forks source link

The scale of "broadened intensities" should be independent of calculator (`SpinWaveTheory` or `dynamical_correlations`) #264

Closed kbarros closed 1 month ago

kbarros commented 2 months ago

The scale of Sunny-calculated dynamical structure factor intensities is should be consistent across calculation methods, following this precise specification.

In Sunny 0.5.11, the result of spin wave calculations (using SpinWaveTheory and intensities_broadened) followed this convention, whereas classical dynamics calculations (using dynamical_sampler and intensities_interpolated) did not.

Concretely, SpinWaveTheory reports intensities as $S(q,\omega)$, while classical dynamics reports intensities as $S(q,\omega) \Delta\omega$. In other words, only the SWT calculation is truly a "density" in energy space.

In Sunny 0.6, this bug is fixed. All calculation methods properly report the structure factor as a density in energy space.

Additional notes:

kbarros commented 1 month ago

Fixed in #272.