Closed ddahlbom closed 1 month ago
Looks good to me, pending Sam's comments on binned intensities. Thanks David.
Hi David, thanks for writing this up.
I think the better way to make this change is to remove the 1/sqrt(n all omega) from the time fft normalization factor. The complete end to end calculation in the time direction is then:
|t-T|
estimates (by fft method), and divide by that number of estimates. This results in a density already! (It's a number that does not go down when the bin size is decreased) (per the discussion around #246 , the overall color scale should have not changed during that, but it turns out it actually did because the aforementioned inclusion of the factor in step 3 happened when that was merged)
See #273
This PR
intensities_interpolated
bysc.Δω
so that the returned values are densities. Ifsc.Δω=NaN
(becausesc
is an instant structure factor) divides by 1 instead.colorrange
s of heatmap plots in examples.