search

SunnySuite / Sunny.jl

Spin dynamics and generalization to SU(N) coherent states
Other
86 stars 19 forks source link

Correcting local field function and MetropolisSampler #56

Closed chaebinkim closed 1 year ago

chaebinkim commented 1 year ago

I revised three things on Sunny,

  1. Correcting _accum_neggrad function with general coupling It was not properly working for antisymmetric exchanges.
  2. Correcting local_energy_change function for dipole_anisotropy MetropolisSampler was not working with dipole_aniostropy.
  3. Adding scalar-biquadratic terms (I know that it is already added in the upcoming refactor, but I don't know how to choose the commits for PR. So, I PR every commit I updated in my repository. I need to learn more about this, sorry for the inconvenience)
kbarros commented 1 year ago

Thank you for finding and fixing this bug. Closing this PR in favor of https://github.com/SunnySuite/Sunny.jl/pull/57 . I tried to give you credit in that new PR by entering the "Co-authored by ..." field. Please check that you are happy with the email address that appears there.