search

SunnySuite / Sunny.jl

Spin dynamics and generalization to SU(N) coherent states
Other
86 stars 19 forks source link

Add feedback optimization for PT temperatures #9

Closed mswwilson closed 2 years ago

kbarros commented 2 years ago

Matt's PT changes look good to me. Also Cole updated some things in the docs regarding the unit system, etc. I think we can accept both, but I'm curious how these two different things ended up in the same PR?

ColeMiles commented 2 years ago

Matt's PT changes look good to me. Also Cole updated some things in the docs regarding the unit system, etc. I think we can accept both, but I'm curious how these two different things ended up in the same PR?

That's on me! I noticed that there were some issues in the docs from when I merged units, and wanted to fix them. Was worried that pushing another commit onto main might introduce merge conflicts and make this PR more complicated to finish, so I asked Matt if I could just append them onto this PR. In hindsight, though, I should not have added it into this PR since it's wholly unrelated. My mistake!

kbarros commented 2 years ago

After some initial confusion, it wasn't a big deal, I could just look at each commit individually.

kbarros commented 2 years ago

OK for me to squash and merge?

ColeMiles commented 2 years ago

I wanted to take a quick look through if that's ok. I can't right now, but I can by the end of the day.

kbarros commented 2 years ago

Of course -- handing off to you.

mswwilson commented 2 years ago

Sounds good. Thanks so much for the suggestions!