search

SunnyXu / SBMLDiagrams

MIT License
5 stars 1 forks source link

Rectangle Arrow Head Shape #84

Closed ethanmizuno16 closed 1 year ago

ethanmizuno16 commented 1 year ago

When trying to call the function sb.setReactionArrowHeadShape, the argument for the shape info list of a rectangle throws an error. I think the image below shows the discrepancies in the SBMLDiagrams code that is causing the issue.

image

SunnyXu commented 1 year ago

I suppose this issue has been fixed in version 1.4.0

hsauro commented 1 year ago

Has it been fixed?

Please confirm.

H

On Thu, Oct 5, 2023 at 10:38 AM Jin XU @.***> wrote:

I suppose this issue has been fixed in version 1.4.0

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/SunnyXu/SBMLDiagrams/issues/84*issuecomment-1749368549__;Iw!!K-Hz7m0Vt54!mveA0hVVZVns6mGql3Od04VRFh7jScF8EF5YogOJJjLou8RsmUqNGVsM8qvG1QSgngWVz751WDmR0GNQ-2X4LWrz1cKk1g$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAIBSDVG6INKKQMUQUT6FY3X53WARAVCNFSM6AAAAAA45LGXD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGM3DQNJUHE__;!!K-Hz7m0Vt54!mveA0hVVZVns6mGql3Od04VRFh7jScF8EF5YogOJJjLou8RsmUqNGVsM8qvG1QSgngWVz751WDmR0GNQ-2X4LWr6ZlFiPA$ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Herbert Sauro, Professor Director: NIH Center for model reproducibility University of Washington, Bioengineering 206-685-2119, www.sys-bio.org, http://reproduciblebiomodels.org/ Mobile: 206-880-8093 @.*** Books: http://books.analogmachine.org/

SunnyXu commented 1 year ago

I have confirmed from my side.

hsauro commented 1 year ago

Ethan can you rerun the tests to confirm it’s fixed at your end?

H

On Mon, Sep 18, 2023 at 2:47 PM ethanmizuno16 @.***> wrote:

When trying to call the function sb.setReactionArrowHeadShape, the argument for the shape info list of a rectangle throws an error. I think the image below shows the discrepancies in the SBMLDiagrams code that is causing the issue.

[image: image] https://urldefense.com/v3/__https://user-images.githubusercontent.com/145398683/268779395-aa628954-fa4a-40b8-a4d9-373298ce7c8a.png__;!!K-Hz7m0Vt54!kVeywRbNS2phLOrUUJfm3frYhpn-JRDlnLAw-vuSsBBy14hEGWBt2rowTY89AxVFJOH9vXpgcNv4od4cASTrm8LUyqUQDg$

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/SunnyXu/SBMLDiagrams/issues/84__;!!K-Hz7m0Vt54!kVeywRbNS2phLOrUUJfm3frYhpn-JRDlnLAw-vuSsBBy14hEGWBt2rowTY89AxVFJOH9vXpgcNv4od4cASTrm8IyEb0_Ug$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAIBSDRTYWH246SKLOTBV7LX3C6NFANCNFSM6AAAAAA45LGXD4__;!!K-Hz7m0Vt54!kVeywRbNS2phLOrUUJfm3frYhpn-JRDlnLAw-vuSsBBy14hEGWBt2rowTY89AxVFJOH9vXpgcNv4od4cASTrm8JixqHjvQ$ . You are receiving this because you are subscribed to this thread.Message ID: @.***>