SunstriderEmu / BugTracker

Endless.gg bugtracker
https://endless.gg
30 stars 25 forks source link

Taint from 'EndlessCollections' #5399

Open jonomurphy opened 11 months ago

jonomurphy commented 11 months ago

Describe the bug Doesn't appear on buggrabber, but received a huge amount of spam with /taint 1 activated:

10/19 19:31:49.147 An action was blocked because of taint from Hello I'm an insecure addon!'); DROP TABLE characters; -- - UNKNOWN 10/19 19:31:49.162 An action was blocked because of taint from Hello I'm an insecure addon!'); DROP TABLE characters; -- - UNKNOWN 10/19 19:31:49.179 An action was blocked because of taint from Hello I'm an insecure addon!'); DROP TABLE characters; -- - UNKNOWN 10/19 19:31:49.195 An action was blocked because of taint from Hello I'm an insecure addon!'); DROP TABLE characters; -- - UNKNOWN

Changed to /taint 2 for specifics, and the perpetrator was 'EndlessCollections'.

Character name Praedon

To Reproduce Verified with another player.

Activate taint logging [set to 2]. No addons enabled, enter game for 5 seconds, check taint log.

N/A

Expected behavior N/A

Screenshots/videos

10/20 00:40:49.379 Execution tainted by EndlessCollections while reading WardrobeFrame - Interface\FrameXML\UIParent.lua:2112 10/20 00:40:49.379 securecall() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:2152 CloseWindows() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:2180 10/20 00:40:49.379 securecall() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:2895 ToggleGameMenu() 10/20 00:40:49.379 TOGGLEGAMEMENU:1 10/20 00:40:49.379 Execution tainted by EndlessCollections while reading CollectionsJournal - Interface\FrameXML\UIParent.lua:2112 10/20 00:40:49.379 securecall() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:2152 CloseWindows() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:2180 10/20 00:40:49.379 securecall() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:2895 ToggleGameMenu() 10/20 00:40:49.379 TOGGLEGAMEMENU:1 10/20 00:40:49.379 Execution tainted by EndlessCollections while reading WardrobeFrame - Interface\FrameXML\UIParent.lua:2112 10/20 00:40:49.379 securecall() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:2152 10/20 00:40:49.379 securecall() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:1381 :ShowUIPanel() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:1311 10/20 00:40:49.379 :SetAttribute() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:1974 ShowUIPanel() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:2901 ToggleGameMenu() 10/20 00:40:49.379 TOGGLEGAMEMENU:1 10/20 00:40:49.379 Execution tainted by EndlessCollections while reading CollectionsJournal - Interface\FrameXML\UIParent.lua:2112 10/20 00:40:49.379 securecall() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:2152 10/20 00:40:49.379 securecall() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:1381 :ShowUIPanel() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:1311 10/20 00:40:49.379 :SetAttribute() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:1974 ShowUIPanel() 10/20 00:40:49.379 Interface\FrameXML\UIParent.lua:2901 ToggleGameMenu() 10/20 00:40:49.379 TOGGLEGAMEMENU:1

Interspersed with about 3000 instances of the following every half a second or so:

10/20 00:40:49.350 An action was blocked because of taint from Hello I'm an insecure addon!'); DROP TABLE characters; -- - UNKNOWN

Additional context

kelno commented 11 months ago

Very clean issue thanks. Can't really dive into it atm but I made a change to reduce the spam already, with next client patch.

jonomurphy commented 11 months ago

Happy to help.