[Core, NPCs] NPC Pets despawn when masters are killed

[ghost]

Decription: An issue with all NPC Pets, causing them to despawn once their masters are killed.

How it works: NPC Pets despawn when their masters are killed.

How it should work:

1. NPC Pets should remain if their masters are killed after engaging in Combat;
2. NPC Pets should despawn only under these circumstances: 2a) if their masters are killed without engaging in Combat (one-shot); 2b) if the Pets go out of Combat after the death of their masters.

This is supposed to affect ALL NPC Pets/Guardians/Minions etc. which are summoned by their respective masters' summoning Abilities (f.ex. Wastewander Shadow Mage's Summon Voidwalker).

Source (you should point out proofs of your report, please give us some source): https://github.com/TrinityCore/TrinityCore/issues/21763 While this report shows post-Wrath video proof, I went out of my way to dig up more, using WoW Classic (Vanilla) footage: https://www.youtube.com/watch?v=s52qPqpe2MM&feature=youtu.be&t=1610 Shadow Mage is killed, but Pet doesn't despawn under the shown circumstances.

Steps to reproduce:

1. Fight an NPC with a Pet;
2. Do the following; 2a) kill the master without engaging in Combat (one-shot); 2b) kill the master after engaging in Combat;
3. Results should be the same -- NPC Pet despawns. As a result, testing by causing the Pet to despawn via going out of Combat is impossible, as it's already despawned.

[ghost]

https://gfycat.com/solidillfatedgoa NPC Pets are still experts at vanishing acts.