search

SunwellTracker / issues

Sunwell Bug Tracker. Frosthold and Angrathar share the core, so all bugs will be fixed on both realms.
43 stars 47 forks source link

[Fishing] [Visual] 'Interrupted' error message when right-clicking bobber. #892

Open TheBigBallsOfFury opened 6 years ago

TheBigBallsOfFury commented 6 years ago

Decription: You get an 'Interrupted' error message when the fishing channel bar is broken by right-clicking bobber to hook fish. This is just a visual bug, the fishing still functions fine.

How it works: Cast fishing, wait for bobber to bounce/splash, then right-click the bobber on the water. You will see 'Interrupted' message in middle of the screen (no addons).

How it should work: Right-click the bobber when it bounces, there should be no 'Interrupted' message when looting fish.

Source (you should point out proofs of your report, please give us some source): https://www.youtube.com/watch?v=dDz-xXkcFS0

Sdyess commented 6 years ago

This is caused by call to Spell::cancel from Unit::InterruptSpell called from GameObject::Use

Spell::cancel will always send SPELL_FAILED_INTERRUPTED as a result, should use FinishSpell instead of InterruptSpell whenever the fishing bobber is used

FALL1N1 commented 6 years ago

https://gist.github.com/FALL1N1/5c48dc53d84b57b4494419c7134b503a you can go without the bool if you want and if you have better data than me, im not sure what other spells use it so i just limited it to fishing

Wojtyas commented 6 years ago

Fixed, will be implemented with next update.

TheBigBallsOfFury commented 6 years ago

Thanks a whole bunch guys. Appreciate your good work!