Fix #385: AttributeError on pickling Django models

Suor / django-cacheops

A slick ORM cache with automatic granular event-driven invalidation.

BSD 3-Clause "New" or "Revised" License

2.12k stars 227 forks source link

Fix #385: AttributeError on pickling Django models #386

Closed itcrab closed 3 years ago

itcrab commented 3 years ago

Fixes #385. Closes #306. Helps with #362.

Suor commented 3 years ago

If you are going to implement custom serializer support that should be done in context of #306 and #362. Some principles I look for:

no new dependencies
simply interface, preferably a single setting
no custom serializers embedded into cacheops code (at least for now)

More in line comments.

itcrab commented 3 years ago

@Suor I finished works by your review - please see my updates.

One comment for your review:

no new dependencies no custom serializers embedded into cacheops code (at least for now)

I remove dill dependency by cacheops as Python package but inside tests env leave dill dependancy and create litle serializer for dill lib - it give us opportunity see that issue problem is fixed right now by this PR.