search

Super-Santa / EssentialAddons

Fabric Carpet extension that adds things from the Spigot plugin Essentials, or other features I think are needed for Minecraft
MIT License
50 stars 8 forks source link

Shadowed players drop their inventory on re-log [FIX] #36

Closed BisUmTo closed 2 years ago

BisUmTo commented 2 years ago

When a player join the server while a bot with the same name is logged, the game will kill the bot. With fakePlayerDropInventoryOnKill enabled, those bot will drop their inventory.

Added the exception in fakePlayerDropInventoryOnKill to not drop items if the reason ok the logout is a duplicate login.

BisUmTo commented 2 years ago

I think it is not neccessary this extra-check for EssentialAddons's fakeplayers... 🤔

senseiwells commented 2 years ago

PlayerFake doesn't have anything to do with reloading fake players, that's for a different rule, reloadFakePlayers uses EntityPlayerMPFake, see here, PlayerFakeEntity is used to create fake players that do not load chunks. See here

senseiwells commented 2 years ago

The previous change to PlayerFakeEntity should be reverted as it's unintended behaviour, these players should not drop items.

senseiwells commented 2 years ago

Should maybe rename this to something like GhostPlayerEntity and the rule too, I can see the reason for confusion xD.

BisUmTo commented 2 years ago

sorry if i caused problems 🙈