This PR simplifies the mixins around minecarts for careful drop and makes them more compatible by only redirecting what's strictly necessary and getting the items from the existing code instead of duplicating vanilla code, meaning other mods can change them and EssentialAddons get the updated ones.
Also removes the dropCartItem rule from the comments in #39, feel free to close if you don't want to do that.
This makes the mod compatible with DropFullCarts, both with and without careful drop enabled (therefore fixes altrisi/DropFullCarts#2).
And adds Eclipse .launch files to .gitignore.
I didn't add #39 in a closes clause given there's still other Inject & Cancels in the mod which IMO aren't a good way to do stuff, but I don't know of any other current issues caused by them.
This PR simplifies the mixins around minecarts for careful drop and makes them more compatible by only redirecting what's strictly necessary and getting the items from the existing code instead of duplicating vanilla code, meaning other mods can change them and EssentialAddons get the updated ones.
Also removes the
dropCartItem
rule from the comments in #39, feel free to close if you don't want to do that.This makes the mod compatible with DropFullCarts, both with and without careful drop enabled (therefore fixes altrisi/DropFullCarts#2).
And adds Eclipse
.launch
files to.gitignore
.I didn't add #39 in a closes clause given there's still other Inject & Cancels in the mod which IMO aren't a good way to do stuff, but I don't know of any other current issues caused by them.