search

SuperBo / fugit2.nvim

Neovim git GUI powered by libgit2
MIT License
386 stars 8 forks source link

feature: pre-commit support #79

Open Kraust opened 3 months ago

Kraust commented 3 months ago

Did you check the docs?

Is your feature request related to a problem? Please describe.

https://pre-commit.com/

AFAIK pre-commit is commonly used in workflows these days, and I include it in mine. Currently fugit2 doesn't ave great support for it. I don't know if libgit2 has proper support for the hooks that pre-commit creates.

Describe the solution you'd like

I'd like the pre-commit hooks to be run on commit (like git commit does) and some kind of indication to the user if the hook fails fails.

Describe alternatives you've considered

This is not a show stopper preventing me from using fugit2. I can just invoke pre-commit manually as part of my workflow (and my CI/CD also runs it).

Additional context

No response

SuperBo commented 3 months ago

Hi @Kraust, pre-commit is not implemented in libgit2 https://github.com/libgit2/libgit2/issues/964. It is the responsibility of IDE/plugin to implement it. In this case, Fugit2 have to handle and call pre-commit command explicitly.

Let's me investigate how to implement it. It may take a while because I'm not so familiar with pre-commit yet.

As always, Thank you for great suggestion! :D