SuperCowPowers / workbench

Workbench: A scalable python framework for security research and development teams.
http://workbench.rtfd.org
MIT License
91 stars 19 forks source link

Fix the tests so they use a coverage module that supports gevent (500 cow points) #137

Open brifordwylie opened 10 years ago

brifordwylie commented 10 years ago

py.test can't use coverage module that supports gevent https://github.com/newbrough/coverage.git. Figure out a path that allows us to use py.test and the test harness which is way better than the old stuff.

brifordwylie commented 10 years ago

this rabbit hole runs deep.. increased cow points to 1000..

brifordwylie commented 10 years ago

Hey the 4.0a0 version of coverage does have some gevent support...

git+https://github.com/nedbat/coveragepy.git

if you call coverage with the '--timid --coroutine=gevent' options it does seems to 'mostly' work. Any work on this issue should start with this version of coveragepy and baseline against it running with these options sets.

Note: Master (7-7-14) has all of these things set, so just running

$ tox
$ coverage report 

Should give you about 79%-80% coverage, be aware that the tox script does a 'coverge combine' as we've spawned the server in as a multiprocess, so the coverage does need to be combined at the end.

brifordwylie commented 10 years ago

So we're now into the 90% coverage range... I'm going to keep this issue open (but moving to 0.4) because even though I think it's basically fixed in coverage 4.0a0 version, it may rear it's ugly head again and at a minimum we should have someone do a 'validation' of the functionality of coverage/gevent.

brifordwylie commented 10 years ago

moving to 0.5

brifordwylie commented 10 years ago

moving to 0.5