TST: Simplify unit tests

SuperDARN / pyDARNio

Python Library for read in SuperDARN data

GNU Lesser General Public License v3.0

8 stars 2 forks source link

TST: Simplify unit tests #8

Open aburrell opened 4 years ago

aburrell commented 4 years ago

Simplify unit tests by:

[x] using one unit test package (unittest, after some discussion with @mts299)
[ ] use subTest to reduce duplication in tests
[ ] use discover and remove main declaration on bottom of current tests

aburrell commented 4 years ago

@mts299 would it be possible to create a data test directory in tests that holds the example files?

aburrell commented 4 years ago

Test files:

[x] unit
- [x] test_borealis.py
- [x] test_conversions.py
- [x] test_dmap.py
- [x] test_superdarn.py
[ ] integration
- [ ] test_borealis.py
- [ ] test_dmap.py
- [x] test_superdarn.py

mts299 commented 4 years ago

Probably is our data is large and if we cut things down we are still requiring the user to essentially install partial files which can still make the package large to install in python terms. Something @mardet987 noticed. I was thinking way back when we could DOI a data test file collection for DAWG software and then just have it curl it down and test via that way.

aburrell commented 4 years ago

I was thinking way back when we could DOI a data test file collection for DAWG software and then just have it curl it down and test via that way.

I'm good with that. Since I assume you have all of these files locally, can you or someone else in your group set it up? At the moment I can't test the changes I'm making locally, so could be introducing bugs.

mts299 commented 4 years ago

Sounds good, but will need to do it next week and need to talk to Kathryn about it.

aburrell commented 4 years ago

Before you save these, can you run it by me? There's a directory structure I'd like to use so that the files can be updated or replaced without breaking the unit tests.