Closed carleyjmartin closed 9 months ago
@carleyjmartin thanks for making those changes - hopefully @Prof-CW agrees / can confirm!
Looks like @Prof-CW agrees with the changes over on the issue #351 , anyone feel free to merge if you like, or let me know if it needs any more changes! :)
Scope
This PR changes the calculation for geographic coordinates of the location of each range gate to include the 'offset' value of boresight from hdw files, and removes the abs() function from bmsep calculation to allow for the correct beam numbers.
As the abs() was originally a bug fix for a colouring-in issue with cartopy plots, this is now taken care of inside the fov method rather than in the position calculation using an if statement.
issue: #351
Approval
Number of approvals: 2 with a quick code review if possible
Test
matplotlib version: 3.7.1 Note testers: please indicate what version of matplotlib you are using
You can plot all the FOV in geographic coordinates, this should colour in the FOv in grey, anything outside should not be shaded:
To check on the direction of beams, you can use the following code:
This code checks the first and 15th beam (red and blue) for a -ve and +ve bmsep value:
These all require Cartopy to be installed - you can remove the projs, coords and coastline keywords to test in magnetic coordinates without cartopy.
Please check out the associated issue for further discussion!