search

SuperDARN / pydarn

Python library for visualizing SuperDARN Data
GNU Lesser General Public License v3.0
31 stars 11 forks source link

Record search tolerance #386

Closed RemingtonRohel closed 1 month ago

RemingtonRohel commented 2 months ago

Scope

Changing the kwargs for plot_fan() to clarify which records to plot. Also refactored embargo code for Fan and RTP classes.

closes #385

Approval

Number of approvals: 1

Test

Test using plot_fan() several different ways:

Also, test plotting old data (older than 1 year) with a negative CPID to verify that the embargo watermark is displayed correctly. Plot with Fan and RTP classes.

carleyjmartin commented 1 month ago

After separating out the embargo fix, all the install errors are gone and I can install fine. I'm still getting the dtime issue when running as:

 rtn = pydarn.Fan.plot_fan(fitacf_data, scan_time=dt.datetime(2020,1,1,0,5),
                              scan_time_tolerance=dt.timedelta(seconds=10),
                              coastline=True, lowlat=30)

I think it's trying to send one of the new keywords through kwargs to the aacgmv2 methods this works as expected when plotting in GEO or new MAG projs.