mts299
commented
2 years ago I would suggest: makebin.linux and makelib.linux
in the CFLAGS+=-fPIC -Wall -pedantic -O3 -D_GNU_SOURCE -D_LINUX line I believe
Open aburrell opened 2 years ago
mts299
commented
2 years ago I would suggest: makebin.linux and makelib.linux
in the CFLAGS+=-fPIC -Wall -pedantic -O3 -D_GNU_SOURCE -D_LINUX line I believe
mts299
commented
2 years ago Seems to have worked for me
cc -fPIC -std=gnu99 -Wall -pedantic -O3 -D_GNU_SOURCE -D_LINUX -D_SVGLIB_ -I/home/marina/superdarn/rst/include/base -I/home/marina/superdarn/rst/include/general -I/home/marina/superdarn/rst/include/superdarn -c trim_snd.c So that would be my suggestion, unless you want it for 1 lib/bin then in its own make file but that is up to you. However, I believe @JWiker had to do this for a fix on his machine so might as well apply on the whole make build system
aburrell
commented
2 years ago That works, thanks for pointing out the makelib.linux line! Now I am running into trouble because the compiler isn't recognizing complex.h in the old AACGM routine 🐞 I haven't been able to track down anything helpful on StackOverflow/google. Any experience with this?
Compiling Binary:/home/aburrell/Git/rst/codebase/analysis/src.bin/aacgm/aacgmeval.1.2
================================================================================
make clean
rm -f *.o
rm -f version.h
rm -f errstr.h
rm -f hlpstr.h
rm -f aacgmeval
make
make.version /home/aburrell/Git/rst/codebase/analysis/src.bin/aacgm/aacgmeval.1.2
make.help
./doc/aacgmeval.doc.xml
cc -fPIC -Wall -pedantic -O3 -D_GNU_SOURCE -D_LINUX -std=gnu99 -D_SVGLIB_ -I/home/aburrell/Git/rst/include/base -I/home/aburrell/Git/rst/include/general -I/home/aburrell/Git/rst/include/analysis -c aacgm.c
mkdir -p /home/aburrell/Git/rst/bin
cc -L/home/aburrell/Git/rst/lib -o /home/aburrell/Git/rst/bin/aacgmeval aacgm.o -Wl,-Bstatic \
-laacgm.1 -lopt.1 -lrtime.1 -laacgm_v2.1 -ligrf_v2.1 -lastalg.1 -Wl,-Bdynamic \
-lm
/home/aburrell/Git/rst/lib/libaacgm.1.a(rylm.o): In function `rylm':
rylm.c:(.text+0x9a): undefined reference to `CMPLX'
rylm.c:(.text+0xb9): undefined reference to `CMPLX'
rylm.c:(.text+0x1bd): undefined reference to `CMPLX'
rylm.c:(.text+0x1ea): undefined reference to `CMPLX'
collect2: ld returned 1 exit status
make: *** [aacgmeval] Error 1
Compilation Aborted.might as well apply on the whole make build system
That's my thought. Could be done outside of the make_fov branch to keep the PR clean and well scoped.
mts299
commented
2 years ago Sounds good but I am not assigning myself to that PR :p I have other things to do :) but should be simple for anyone todo minus whatever the fix is for complex.h
aburrell
commented
2 years ago Really hopeful someone else has encountered the complex.h error
BUG
When compiling my code on:
LSB Version: :base-4.0-amd64:base-4.0-noarch:core-4.0-amd64:core-4.0-noarch:graphics-4.0-amd64:graphics-4.0-noarch:printing-4.0-amd64:printing-4.0-noarch Distributor ID: CentOS Description: CentOS release 6.10 (Final) Release: 6.10 Codename: Final
with:
cc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23) Copyright (C) 2010 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
I get the following error:
I tried the suggested fix out in the problem directory, and it appeared to work:
The output from this call is:
rcdf.c: In function ‘RCDFReadZ’: rcdf.c:221: warning: pointer of type ‘void ’ used in arithmetic rcdf.c: In function ‘RCDFReadR’: rcdf.c:332: warning: pointer of type ‘void ’ used in arithmetic rcdf.c: At top level: /home/aburrell/bin/cdf38_0-dist/include/cdf.h:81: warning: ‘TT2000NULL’ defined but not used
and none of those are errors, yay! However, I can't find the correct place to add the
-std=gnu99flag so that the makefiles and make scripts will use it. I tried altering $RSTPATH/build/make/makebin.linux by adding-std=gnu99to the end of the first line of code. Although this seems like it should work, it doesn't?This is currently preventing me from using RST. There are issues with the newer computer I was using, so we were booted back to an older system. This system has previously successfully installed RST.
Priority
RST version
Does the bug occur in an official RST release?
Example of the bug
See first section
Attempts
See first section
Data Access
N/A
Potential Bug Location
$RSTPATH/build/make/makebin.linux
Potential Solution(s)
See first section
Extra Notes
See first section