[BUG] make_grid producing partial record files for the whole 2hr file

[mts299]

BUG

Trying to test pyDARN with grid plotting then convection mapping, I found out 20220108 (normal scan day) produces grid files that contain all partial records (no vector. fields in the file). Looking at https://superdarn.ca/summary-plots there is data, the cpid is not abnormal and this happens also on southern hemisphere data DCN did the same thing.

This happens on fitacf 2.5 and 3.0 but 2.5 sometimes have a few full records but still sparse.

Priority

• [ ] Minor - typo, incorrect naming, fails in a specific uncommon situation
• [x] Major - misrepresentation of data, failure in a common situation
• [ ] Urgent - failure in usage, large misrepresentation of data

RST version

• [x] Yes. RST version: master
• [x] No. Branch containing the bug (e.g. develop): develop

Example of the bug

make_grid 20220108.0000.00.sas.a.fitacf > 20220108.0000.00.sas.a.grid
dmapdump 20220108.0000.00.sas.a.grid | less
scalars:
        short   "start.year" = 2022
        short   "start.month" = 1
        short   "start.day" = 8
        short   "start.hour" = 0
        short   "start.minute" = 1
        double  "start.second" = 0.027393
        short   "end.year" = 2022
        short   "end.month" = 1
        short   "end.day" = 8
        short   "end.hour" = 0
        short   "end.minute" = 3
        double  "end.second" = 0.027393
arrays:
        short   "stid" [1]
        short   "channel" [1]
        short   "nvec" [1]
        float   "freq" [1]
        short   "major.revision" [1]
        short   "minor.revision" [1]
        short   "program.id" [1]
        float   "noise.mean" [1]
        float   "noise.sd" [1]
        short   "gsct" [1]
        float   "v.min" [1]
        float   "v.max" [1]
        float   "p.min" [1]
        float   "p.max" [1]
        float   "w.min" [1]
        float   "w.max" [1]
        float   "ve.min" [1]
        float   "ve.max" [1]
scalars:
        short   "start.year" = 2022
        short   "start.month" = 1

There is no vector. fields in the following file

Attempts

Have not fully looked into but looks to be more current in 2022 data (I could be wrong) and if it happens to 1 file seems to apply to others for that day. My best guess if its some check grid does to determine the data is not useful. Again I am not 100% what is going on in make_grid and the full understanding of the science.

Data Access

You can obtain fitacf 2.5, 3.0, and despecked 3.0 files on globus if you contact me if you want to test this

[mts299]

Found the solution... it is already fixed. Unfortuanatley I forgot update a branch on HPC machine that allows me to compile it there. #462 is the fix.