search

SuperDARN / rst

Radar Software Toolkit (RST)
https://superdarn.github.io/rst/
GNU General Public License v3.0
22 stars 18 forks source link

Adding Iceland East and West hdw files and updating radar.dat #558

Closed egthomas closed 1 year ago

egthomas commented 1 year ago

This pull request adds hardware files for the new Iceland East and West radars, and updates the radar.dat file accordingly.

egthomas commented 1 year ago

Merging with approval from the radar PI (@sshepherd) and after running multi-frequency tests to validate tdiff.

ksterne commented 1 year ago

Sorry to be slow on this @egthomas, thanks for confirming this with the radar PI, I was wondering if that would be distributed around or if someone would confirm these. I suspect if there's any corrections, they can be made later.

sshepherd commented 1 year ago

Hi Kevin, I’m not sure if there is a question in your email. If there is then let me know. The Iceland radars have been collecting data for close to a month. I shared the hardware files after we had all of the antennas up and the cables laid. These files have tdiff values. Hardware files can always be changed and should be, particularly when there are changes to a radar. The most common change is something that affects tdiff; electronics, new cables, etc. Those values should be updated as frequently as they changed and as soon as possible so that the data is useful. We are trying to get these values out so that the data we have been collecting is of use.

Simon

On Wed, Feb 22, 2023 at 1:01 PM Kevin Sterne @.***> wrote:

Sorry to be slow on this @egthomas https://github.com/egthomas, thanks for confirming this with the radar PI, I was wondering if that would be distributed around or if someone would confirm these. I suspect if there's any corrections, they can be made later.

— Reply to this email directly, view it on GitHub https://github.com/SuperDARN/rst/pull/558#issuecomment-1440517387, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWYGPZUMCHPN4LDARVRF5TWYZH6FANCNFSM6AAAAAAU6SAGWY . You are receiving this because you were mentioned.Message ID: @.***>

ksterne commented 1 year ago

Hello Simon,

There wasn't any implied question in my post to this closed pull request, my apologies if it seemed like there was one. I understand you receive this by e-mail but just to be clear it is in the open (publicly available) on the github repo. My apologies for missing the hdw.dat files being shared; I don't think I received those by e-mail, but maybe they were shared another way. I agree with your notes about why and when hdw.dat files should be changed and updated. To clarify the last sentence on my previous post, I meant that if a mistake had been made from what was being added to this repo and what you had shared (basically if there was a copy and paste error), then we could correct that in the future. I hope this clears up what I was commenting on.