search

SuperDARN / rst

Radar Software Toolkit (RST)
https://superdarn.github.io/rst/
GNU General Public License v3.0
21 stars 16 forks source link

Added CI compilation test #575

Closed aburrell closed 1 month ago

aburrell commented 1 year ago

Added a continuous integration (CI) framework, which currently just tests whether or not RST compiles based on our current instructions.

ksterne commented 10 months ago

I think the basic test here is that this branch still compiles? And I guess a double check that the github workflow has been setup correctly? It looks like all of that has been done! Awesome catch that github has this feature now. We'd lost that with the restrictions travis CI put in place from my vague memory.

egthomas commented 10 months ago

@aburrell thanks for addressing my previous comments. Just to follow on, would this still work if the requirements.ubuntu file is located in the .github/workflows directory?

ksterne commented 9 months ago

@aburrell giving this a bump as well. Let me know if you're able to add your authorship to the file and can you test the change in file location @egthomas was wondering about?

ksterne commented 9 months ago

Hello @aburrell, similarly on this pull request, do you think you can take a look these two things? If it's helpful, I can try to help answer the question @egthomas brought up.

aburrell commented 8 months ago

Looking for an easy win today so came back here 😀

@egthomas - Honestly, I think having a requirements file that's easy for people installing to find and use would be good to have in the top level directory, but it doesn't matter where it lives. For now I've put it where you requested, but made it visible. Maybe in the future we can have a Requirements directory or something that helps with the installation.

@ksterne - Updated the zenodo json and the authors file.

egthomas commented 8 months ago

@aburrell thanks for making those changes! It looks like the compilation test is currently failing because it can't find the requirements file:

cat: .github/workflow/requirements.ubuntu: No such file or directory

https://github.com/SuperDARN/rst/actions/runs/6408566485/job/17397848606#step:3:49

aburrell commented 8 months ago

@egthomas the requirements file needs to be somewhere in the main tree for it to be accessible when building. I moved it to be a hidden file in the build directory for now.

aburrell commented 8 months ago

RTD failure documented in #601

ecbland commented 8 months ago

@aburrell I've added a new configuration file for readthedocs. The build is working now.

aburrell commented 1 month ago

@ksterne pinging you for a review. I don't care about adding authorship for the yaml, given that it's copypasta from other projects and not original creative property.