search

SuperDARN / rst

Radar Software Toolkit (RST)
https://superdarn.github.io/rst/
GNU General Public License v3.0
21 stars 16 forks source link

Modifying FitDecode of fit library to check against both phi0 and elv #592

Closed egthomas closed 9 months ago

egthomas commented 9 months ago

This pull request modifies FitDecode of the fit library to check against both the phi0 and elv fields when reading fitted XCF data to determine whether to populate the XCF arrays. This is necessary because older radars do not transmit all of the fitted parameters in real-time (ie phi0), meaning that the elevation angles were not being populated when received by modern routines (eg fitacfclientgui).

ecbland commented 9 months ago

@egthomas This branch compiles ok and the change looks sensible. Do you have a fitacf file that includes the elv parameter but not phi0 that I can use to test? No worries if not.

egthomas commented 9 months ago

@ecbland thanks for testing. No unfortunately I don't have an example FITACF file, but I could share an example real-time link from an older radar via email if that helps.

ecbland commented 9 months ago

I think this is fine to merge as-is.

egthomas commented 9 months ago

Thanks @ecbland!