Bugfix: setting `xqflg` to zero in `fit_speck_removal`

SuperDARN / rst

Radar Software Toolkit (RST)

https://superdarn.github.io/rst/

GNU General Public License v3.0

21 stars 16 forks source link

Bugfix: setting `xqflg` to zero in `fit_speck_removal` #612

Closed ecbland closed 2 months ago

ecbland commented 2 months ago

This PR fixes a bug identified by @pasha-ponomarenko in fit_speck_removal. For radars with xcf=1, the XCF quality flag also needs to be set to zero. This bug was not obvious when reading the output files using standard RST C code, but it does become apparent when reading the data with IDL.

pasha-ponomarenko commented 2 months ago

I have deployed the branch and tested it against HOK and HKW data for 20_22UT on 05 November 2018, which contain a lot of 'salt-and-pepper' noise caused by their mutual cross-interference. With the updated script both datasets are processed properly, i.e., the specks are effectively filtered out (see examples below).

HOK unfiltered

HOK filtered

HKW unfiltered

HKW filtered

pasha-ponomarenko commented 2 months ago

I guess I can merge it now, although there is a warning "All checks failed", which refers to Read the Docs. Is it important?