Closed klepp0 closed 1 month ago
@klepp0 great PR! A few things:
- Can you incorporate the suggestion to add
@ensure_initialized
?- Can you include the
@merge_docstrings
decorator?This will require you to apply the metaclass to
Leaf
and not toComponent
. I'm sorry if this is a lot to request, but great job for getting this far anyhow.
Hi @klepp0 would you be able to connect with us in the public slack? https://superduperdb.slack.com/join/shared_invite/zt-1zuojj0k0-RjAYBs1TDsvEa7yaFGa6QA#/shared-invite/email
Hey @blythed, thanks for the prompt response. I'll tackle those changes next week if that works for you.
Hi @klepp0 we cherry picked some of your commits in #2144 and merged that, as we are working towards a deadline. Thanks for you help! You're commits will appear in the main
branch and v0.2
release.
Hey @blythed, since the issue #2129 is still open, do you still need someone to include your suggestions from above? If so, I could start working on it tomorrow and finish what I started. Let me know 🙂
Description
This introduces the new meta class
AutoDataclassMeta
to avoid repetitive calling of thedc.dataclass
decorator. The changes involve refactoring theComponent
class and docs updates.Related Issues
Remove dataclass wrappers (fix #2129)
Checklist
make unit_testing
andmake integration-testing
successfully?Additional Notes or Comments
.ipynb
files.make ext_testing
instead of `make integration-testing. I assume the checklist above is out of date?test_unstructured.py
module failed. It also fails on the main branch so I didn't investigate it further.