SuperDuperDB / superduperdb

🔮 SuperDuperDB: Bring AI to your database! Build, deploy and manage any AI application directly with your existing data infrastructure, without moving your data. Including streaming inference, scalable model training and vector search.
https://superduperdb.com
Apache License 2.0
4.55k stars 445 forks source link

Remove dataclass wrappers #2136

Closed klepp0 closed 1 month ago

klepp0 commented 1 month ago

Description

This introduces the new meta class AutoDataclassMeta to avoid repetitive calling of the dc.dataclass decorator. The changes involve refactoring the Component class and docs updates.

Related Issues

Remove dataclass wrappers (fix #2129)

Checklist

Additional Notes or Comments

blythed commented 1 month ago

@klepp0 great PR! A few things:

  • Can you incorporate the suggestion to add @ensure_initialized?
  • Can you include the @merge_docstrings decorator?

This will require you to apply the metaclass to Leaf and not to Component. I'm sorry if this is a lot to request, but great job for getting this far anyhow.

Hi @klepp0 would you be able to connect with us in the public slack? https://superduperdb.slack.com/join/shared_invite/zt-1zuojj0k0-RjAYBs1TDsvEa7yaFGa6QA#/shared-invite/email

klepp0 commented 1 month ago

Hey @blythed, thanks for the prompt response. I'll tackle those changes next week if that works for you.

blythed commented 1 month ago

Hi @klepp0 we cherry picked some of your commits in #2144 and merged that, as we are working towards a deadline. Thanks for you help! You're commits will appear in the main branch and v0.2 release.

klepp0 commented 3 weeks ago

Hey @blythed, since the issue #2129 is still open, do you still need someone to include your suggestions from above? If so, I could start working on it tomorrow and finish what I started. Let me know 🙂