STYLE: Remove `NumberOfWeights` from RecursiveBSpline WeightFunction

SuperElastix / elastix

Official elastix repository

http://elastix.dev

Apache License 2.0

449 stars 110 forks source link

STYLE: Remove `NumberOfWeights` from RecursiveBSpline WeightFunction #1100

Closed N-Dekker closed 2 months ago

N-Dekker commented 2 months ago

RecursiveBSplineInterpolationWeightFunction::NumberOfWeights was never used. Its value (SplineOrder + 1) * SpaceDimension was different from both BSplineInterpolationWeightFunctionBase::NumberOfWeights and RecursiveBSplineInterpolationWeightFunction::m_NumberOfWeights (both equivalent to pow(SplineOrder + 1, SpaceDimension)), which appeared somewhat confusing.

N-Dekker commented 2 months ago

Discussed with @stefanklein and @whuizinga, starting at https://github.com/SuperElastix/elastix/pull/1099#issuecomment-2061492736 So if this particular definition of NumberOfWeights isn't used anywhere (anymore), it can be removed. 👍