search

SuperElastix / elastix

Official elastix repository
http://elastix.dev
Apache License 2.0
449 stars 110 forks source link

Add macos-14 in CI #1105

Open thewtex opened 2 months ago

thewtex commented 2 months ago

This is an ARM architecture mac system aka Apple Silicon.

This will add more compiler checks. In https://github.com/InsightSoftwareConsortium/ITKElastix/pull/278 we also observe numerical differences at the application level -- the test suite might provide more insights.

N-Dekker commented 2 months ago

@thewtex Thanks for the suggestion, but all I got so far from upgrading to macos-14 (branch https://github.com/SuperElastix/elastix/tree/GitHubActions-macos-14) are extra warnings, at https://my.cdash.org/viewBuildError.php?type=1&buildid=2550398 saying:

ld: warning: ignoring duplicate libraries: '-lm', '/.../ITK-build/lib/libITKCommon-5.4.a', ...

🤷

thewtex commented 1 month ago

@N-Dekker I addressed these warnings in ITK via https://github.com/InsightSoftwareConsortium/ITK/pull/4519/commits/7231bf793f552517e309a354ee5643b3f2967ed0 -- bumping ITK should do the trick!

N-Dekker commented 1 month ago

Now trying to upgrade: https://github.com/SuperElastix/elastix/tree/Upgrade-ITK-to-v5.4rc04