search

SuperElastix / elastix

Official elastix repository
http://elastix.dev
Apache License 2.0
474 stars 116 forks source link

STYLE: Remove `samplenr` which was used in commented-out code in Compute #1112

Closed N-Dekker closed 3 months ago

N-Dekker commented 4 months ago

This particular samplenr variable was only used as argument for commented-out progressObserver->UpdateAndPrintProgress calls.

Those progressObserver->UpdateAndPrintProgress calls were already commented-out with commit e9de4b1281a07d2fdbaa96db865f3c7aaaf4e5d2 (May 25, 2016): https://github.com/SuperElastix/elastix/blob/e9de4b1281a07d2fdbaa96db865f3c7aaaf4e5d2/src/Common/itkComputeJacobianTerms.hxx#L235-L236

Follow-up to pull request https://github.com/SuperElastix/elastix/pull/1111 "COMP: Fix -Wshadow warnings on local samplenr variable"

N-Dekker commented 3 months ago

@mstaring FYI, I'll just merge this PR now, but if we ever want to have this unused variable (samplenr) back here (and actually use it to implement progress updating), it's easy to put it back any time later.