search

SuperElastix / elastix

Official elastix repository
http://elastix.dev
Apache License 2.0
449 stars 110 forks source link

Enable and address `-wshadow` warnings from both GCC and clang #1115

Closed N-Dekker closed 1 month ago

N-Dekker commented 1 month ago

Enabled and addressed -wshadow warnings, triggered by comments by Bradley Lowekamp (@blowekamp) from https://github.com/SimpleITK/SimpleITK/pull/2104#issuecomment-2075030813

The warnings are addressed by choosing more specific (more distinguishing) identifiers, removing unnecessary types and variables, reducing the scope of variables, and using modern C++ enum classes.

blowekamp commented 1 month ago

Nice work!