Enable and address `-woverloaded-virtual` warnings from GCC or clang

SuperElastix / elastix

Official elastix repository

http://elastix.dev

Apache License 2.0

449 stars 110 forks source link

Enable and address `-woverloaded-virtual` warnings from GCC or clang #1122

Closed N-Dekker closed 1 month ago

N-Dekker commented 1 month ago

Addressed those warnings, mostly from macos-12/clang.

Note that these warnings do sometimes help to find actual (potential) bugs, like:

pull request #1120
pull request #1118
pull request #1123

Follow-up to:

pull request #1115

N-Dekker commented 1 month ago

@blowekamp Regarding https://github.com/SimpleITK/SimpleITK/pull/2104#issuecomment-2075743756 FYI, I finally fixed all (999+) -Woverloaded-virtual warnings in elastix, with this pull request. All -Wshadow are also fixed now (#1115). I will still have a look at -Wunused-parameter, though...!