SuperElastix / elastix

Official elastix repository
http://elastix.dev
Apache License 2.0
449 stars 110 forks source link

COMP: Remove unused parameter `mu` from ComputeJacobiTypePreconditioner #1133

Closed N-Dekker closed 1 month ago

N-Dekker commented 1 month ago

Fixed GCC warning -Wunused-parameter.

ComputeJacobiTypePreconditioner was introduced with commit 70829754af29b92cb34be5997cda8216eaf6be8c "ENH: merging performance into develop branch", 7 Mar 2019. With that initial commit, the mu parameter of this member function was already unused.

Also removed the virtual keyword from the member function declaration. This member function did not have any override anyway. Following C++ Core Guidelines, May 11, 2024 "Don’t make a function virtual without reason", http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-virtual