The old "itkPCAMetric.h" and "itkPCAMetric.hxx" files were not being used anymore. They were not even #include'd anywhere. Moreover, they cannot even be used anymore, because they would then conflict with "itkPCAMetric_F_multithreaded.h" and "itkPCAMetric_F_multithreaded.hxx", which define a class template with exactly the same name! Using both "itkPCAMetric_F_multithreaded" and "itkPCAMetric" would probably cause link errors, or otherwise maybe undefined behavior.
Removing these source files eases further maintenance of elastix, including uncoming changes regarding the SubtractMean parameter (pull request #1104)
@mstaring @stefanklein Do you agree that the old "itkPCAMetric.h" and "itkPCAMetric.hxx" files may be removed? And that we can then rename those "itkPCAMetric_F_multithreaded" files to "itkPCAMetric"?
The old "itkPCAMetric.h" and "itkPCAMetric.hxx" files were not being used anymore. They were not even
#include'd anywhere. Moreover, they cannot even be used anymore, because they would then conflict with "itkPCAMetric_F_multithreaded.h" and "itkPCAMetric_F_multithreaded.hxx", which define a class template with exactly the same name! Using both "itkPCAMetric_F_multithreaded" and "itkPCAMetric" would probably cause link errors, or otherwise maybe undefined behavior.SubtractMeanparameter (pull request #1104)@mstaring @stefanklein Do you agree that the old "itkPCAMetric.h" and "itkPCAMetric.hxx" files may be removed? And that we can then rename those "itkPCAMetric_F_multithreaded" files to "itkPCAMetric"?