search

SuperElastix / elastix

Official elastix repository
http://elastix.dev
Apache License 2.0
474 stars 116 forks source link

BUG: Add ComputeZYX to FixedParameters of AdvancedEuler3DTransform #1156

Closed N-Dekker closed 3 months ago

N-Dekker commented 3 months ago

Following ITK commit https://github.com/InsightSoftwareConsortium/ITK/commit/47c24916609afbd078f2fc51d81962a62be08f7a "BUG: Interpretation of the Euler angles ZYX or ZXY was not exported.", Ziv Yaniv (@zivy), May 9, 2016.

Implementation of GetFixedParameters, SetFixedParameters, and SetComputeZYX mostly copied from "itkEuler3DTransform.h" and "itkEuler3DTransform.hxx", in https://github.com/InsightSoftwareConsortium/ITK/tree/v5.4.0/Modules/Core/Transform/include

GoogleTest TransformedPointSameAsITKEuler3D extended to test ComputeZYX = true. DefaultElastixFixedParametersAreZeroOrEmpty test adjusted to allow fixedParameters.size() unequal to NDimension. CopyDefaultEulerTransformElastix3DFixedParametersToCorrespondingItkTransform test removed, as 3D EulerTransform is now fully covered by the CopyDefaultParametersToCorrespondingItkTransform test.