SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

Feature: Visual Skill Tier #100

Closed Skillz4Killz closed 7 years ago

Skillz4Killz commented 7 years ago

The current ST number of 0-29 does no one any good except knowing what skill tier someone is. The actual numerical value of VST would be so much better and provide so much more potential tools to developers who can build an insane amount of stuff with it.

Furthermore, the numbers 0-29 can be figured out by the numerical value.

Thank You

kvahuja commented 7 years ago

i second that. number would be far more valuable that a simple Tier Value can be

BrianGLHF commented 7 years ago

This FR has been recreated on FeatHub at http://feathub.com/madglory/gamelocker-vainglory/+3

svperfecta commented 7 years ago

I think we're going to close this one, since the number can be calculated with the provided map in the resources folder.

https://github.com/madglory/gamelocker-vainglory/blob/master/resources/skillTiers.json

Skillz4Killz commented 7 years ago

@genexp I think you misunderstood. The number we are requesting is the numerical representation of Visual Skill Tier. API is currently giving us a number from -1-29. However, in game this number is shown as 0-3000. This number is what the community has been asking for. I think this issue may need to be reopened.

svperfecta commented 7 years ago

Hey dude - You're right, sorry! Trying to close as many as I can. :)

Is this what you're looking for?

    109, #  0-1  "Just Beginning" Bronze Max
    218, #  1-1  "Just Beginning" Silver Max
    327, #  2-1  "Just Beginning" Gold Max
    436, #  3-2  "Working On It" Bronze Max
    545, #  4-2  "Working On It" Silver Max
    654, #  5-2  "Working On It" Gold Max
    763, #  6-3  "Getting There" Bronze Max
    872, #  7-3  "Getting There" Silver Max
    981, #  8-3  "Getting There" Gold Max
    1090, #  9-4  "Not Bad" Bronze Max
    1200, # 10-4  "Not Bad" Silver Max
    1250, # 11-4  "Not Bad" Gold Max
    1300, # 12-5  "Decent-ish" Bronze Max
    1350, # 13-5  "Decent-ish" Silver Max
    1400, # 14-5  "Decent-ish" Gold Max
    1467, # 15-6  "Pretty Good" Bronze Max
    1533, # 16-6  "Pretty Good" Silver Max
    1600, # 17-6  "Pretty Good" Gold Max
    1667, # 18-7  "The Hotness" Bronze Max
    1733, # 19-7  "The Hotness" Silver Max
    1800, # 20-7  "The Hotness" Gold Max
    1867, # 21-8  "Simply Amazing" Bronze Max
    1933, # 22-8  "Simply Amazing" Silver Max
    2000, # 23-8  "Simply Amazing" Gold Max
    2133, # 24-9  "Pinnacle of Awesome" Bronze Max
    2267, # 25-9  "Pinnacle of Awesome" Silver Max
    2400, # 26-9  "Pinnacle of Awesome" Gold Max
    2600, # 27-10 "Vainglorious" Bronze Max
    2800, # 28-10 "Vainglorious" Silver Max
schneefux commented 7 years ago

We're looking for the exact number on the first column of your table.

BrianGLHF commented 7 years ago

A visualization may help here.

image of VST on in game profile

For the sake of simplicity the display for VST has 3 core parts.

  1. the skill tier name (as represented in API by -1 through 29)
  2. the skill tier color (as represented in API by -1 through 29)
  3. the actual VST number (shown as 1462 for this player in this image)

Community developers are looking for the third item on the list. Having the actual VST number would allow community developers to create dynamic VST meters showing a players exact VST much like it is shown in the game.

svperfecta commented 7 years ago

Ok, thanks for for the help. Hard sometimes finding things.. I found them! We have VST for each season and will add.

svperfecta commented 7 years ago

Done