Feature: Open the schema validator

[schneefux]

@genexp mentioned that you have a schema validator that you use internally (and that it is currently quite relaxed).

I'm proposing to open the validator, so that application developers know what kind of data to anticipate, and so that we can comment and improve the validation and run it by ourselves to ensure that no unexpected data reaches our applications.

[svperfecta]

This is an excellent idea!

I'd like to do this with art assets too until we get something better. Lovely idea On Wed, Apr 12, 2017 at 8:31 AM schneefux notifications@github.com wrote:

@genexp https://github.com/genexp mentioned that you have a schema validator that you use internally (and that it is currently quite relaxed).

I'm proposing to open the validator, so that application developers know what kind of data to anticipate, and so that we can comment and improve the validation and run it by ourselves to ensure that no unexpected data reaches our applications.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/madglory/gamelocker-vainglory/issues/148, or mute the thread https://github.com/notifications/unsubscribe-auth/AAADMJYA6kFLYZb2QsHph4B_aoTN18qDks5rvMQNgaJpZM4M7W2X .

[kvahuja]

http://json-schema.org/ is what we are referring to :)

also, any idea of by when you may plan this? because we may do it on our side in case this is like 6 months away.

[bguilder]

@kvahuja we are actually using http://jsonapi.org/

No timeline right now, but we'll be sure to make it public once we make a final decision.

[svperfecta]

We use an internal validation library. We need to create a Jason schema def and pass it by a couple thousand ap responses. Just haven't had time.

The plan it to start loose enough that everything currently passes and request pull requests to tighten it down.

On Tue, Apr 18, 2017 at 12:25 PM Brian Guilder notifications@github.com wrote:

@kvahuja https://github.com/kvahuja we are actually using http://jsonapi.org/

No timeline right now, but we'll be sure to make it public once we make a final decision.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/madglory/gamelocker-vainglory/issues/148#issuecomment-294953288, or mute the thread https://github.com/notifications/unsubscribe-auth/AAADMIiHXE9zhaUQCtpLVcGtVAdX8HNAks5rxQ4LgaJpZM4M7W2X .

[svperfecta]

Done!