search

SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

Feature: participant should have "surrendered" attribute #244

Closed schneefux closed 5 years ago

schneefux commented 7 years ago

In a standard match, a player can press a "surrender" button from 15 minutes onwards (earlier in Brawl modes or under special team AFK conditions). The team can then vote to surrender. With three :heavy_check_mark: (100%), the vote passes immediately. Recently, SEMC introduced a rule that allows the vote to pass with two :heavy_check_mark: (66%) after the fifth attempt at the vote.

The API has match.attributes.stats.endGameReason "surrender" in such a case, and the roster that lost will have won "false", so in the 100% case it can be inferred whether a participant voted for surrender.

In the 66% case, it is not possible. Plus, the attribute should not need to be inferred. I'm suggesting:

      "type": "participant",
      "id": "1034a2f0-7e7d-11e7-a690-3ef0289d46af",
      "attributes": {
        "actor": "*Kestrel*",
        "shardId": "cn",
        "stats": {
          "surrendered": true,
          …