search

SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

Bug: roster.attributes.won should be a boolean #245

Closed schneefux closed 6 years ago

schneefux commented 7 years ago

roster.attributes.won is a stringified boolean. It should be a boolean. Current vs. suggested: "false" vs. false "true" vs. true

For consistency, the value should be at roster.attributes.stats.winner to have the same path as participant.attributes.stats.winner.

Example of the current data:

      "type": "roster",
      "id": "78efbe48-7e7b-11e7-b841-3aec21ed2cb2",
      "attributes": {
        "shardId": "cn",
        "stats": {
          "acesEarned": 1,
          "gold": 62882,
          "heroKills": 23,
          "krakenCaptures": 1,
          "side": "right/red",
          "turretKills": 3,
          "turretsRemaining": 0
        },
        "won": "false"
      },
ghost commented 7 years ago

I can confirm this. Please fix. It is string instead of boolean.

schneefux commented 6 years ago

Still a string

kvahuja commented 6 years ago

@jaloisi834 is this fixed-closed or ignored-closed?

jaloisi834 commented 6 years ago

@kvahuja great question. Sorry I didn't add a note on here before closing. We discussed this, and decided that the requested change would likely do more harm than good since it would require any service/project using the API to be refactored which we try to avoid.