SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

Added some more jsons to resources #246

Closed ClarkThyLord closed 7 years ago

ClarkThyLord commented 7 years ago

Changes proposed:

schneefux commented 7 years ago

Cool!

Skillz4Killz commented 7 years ago

@ClarkThyLord Wouldn't it be better to have them written as

{
        "name": "Buff_CelesteCore_Collapse",
        "friendlyName": "Core Collapse Buff",
 },

Instead of what is currently written as

{
        "name": "Buff_CelesteCore_Collapse",
        "friendlyName": "Celeste B",
 },

The friendly name should represent what the user will be outputting on their project in my opinion as opposed. For example, a project should not show the output to the user as Celeste B but instead call it by its name as Core Collapse Buff. Furthermore, the Celeste B doesn't help clarify the difference between Celeste ability and the buff.

schneefux commented 7 years ago

Add meta information fields "actor": "Celeste", "category": "B" as a compromise. Both strings contain valuable information.

ClarkThyLord commented 7 years ago

you guys are more then welcomed to edit those things in 🤗