search

SuperEvilMegacorp / vainglory-assets

Community provided art, schemas, and other assets that make using the Vainglory API easier
https://developer.vainglorygame.com
MIT License
54 stars 40 forks source link

Feature: Remove lifetimeGold from player objects #253

Closed schneefux closed 6 years ago

schneefux commented 7 years ago

As written in #219 by genexp:

Lifetime gold is poorly named, as we know. It actually means "gold earned in a match" and we put it in the wrong location (I think we put it on profiles, it should on participant). I can can get approval from you guys to move it, i'll put it where it belongs (on participant). Should only take me 30 minutes or so to fix and update the tests. NOTE: If we agree on this solution, we can split this out, categorize as a bug, mark in-progress and assign to guilder.

The value is already present in participant.attributes.stats.gold.

+1 for just removing it from me and @kvahuja. I will need to update our backend for this breaking change, so a notice 24h before you deploy would be nice.

Skillz4Killz commented 7 years ago

@genexp this is the lifetime gold issue from the player object so no need to make another duplicate

jaloisi834 commented 6 years ago

Player lifetime gold has been hardcoded to 0, and will be removed eventually (after the 120 day retention period has passed). We will notify everyone prior to its removal.